Skip to content

Fix 9669 - Crash when running a simulation with MultiZoneWithoutDistribution and fan#11383

Merged
mitchute merged 2 commits intoNatLabRockies:developfrom
bigladder:Fix-9669-Crash-when-running-a-simulation-with-MultiZoneWithoutDistribution-and-fan
Jan 8, 2026
Merged

Fix 9669 - Crash when running a simulation with MultiZoneWithoutDistribution and fan#11383
mitchute merged 2 commits intoNatLabRockies:developfrom
bigladder:Fix-9669-Crash-when-running-a-simulation-with-MultiZoneWithoutDistribution-and-fan

Conversation

@kevin-moos
Copy link
Contributor

@kevin-moos kevin-moos commented Dec 19, 2025 •
edited
Loading

Pull request overview

Description of the purpose of this PR

When distribution_simulated is false, LoopOnOffFanRunTimeFraction is not allocated so these nested loops can be skipped. Even if we instead allocate LoopOnOffFanRunTimeFraction, the default value of 0 still wouldn't meet the conditions for anything to reported so I just added a check for !distribution_simulated.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@kevin-moos kevin-moos marked this pull request as ready for review December 22, 2025 17:23
rraustad
rraustad reviewed Jan 7, 2026
View reviewed changes
src/EnergyPlus/AirflowNetwork/src/Solver.cpp

for (AirLoopNum = 1; AirLoopNum <= NumPrimaryAirSys; ++AirLoopNum) {
if (DisSysNumOfCVFs == 0) {
if (DisSysNumOfCVFs == 0 || !distribution_simulated) {
Copy link
Collaborator

@rraustad rraustad Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix. I guess another way would be to make sure whatever array crashed (assuming that is what happened) was allocated? This is probably the easiest and cleanest fix, so this is good.

    CurrentModuleObject = "AirflowNetwork:Distribution:Component:Fan";
    DisSysNumOfCVFs = m_state.dataInputProcessing->inputProcessor->getNumObjectsFound(m_state, CurrentModuleObject);

I wonder if other components could cause the same type of crash? Maybe not since the AFN Coil component works in the unit test. For example:

AirflowNetwork:Distribution:Component:HeatExchanger
AirflowNetwork:Distribution:Component:TerminalUnit

Copy link
Collaborator

@mitchute mitchute Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This looks OK. distribution_simulated is checked in a bunch of different places, so this is inline with what we're already doing.

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Jan 7, 2026
@mitchute mitchute merged commit 08cfd5a into NatLabRockies:develop Jan 8, 2026
11 of 12 checks passed
@mitchute mitchute deleted the Fix-9669-Crash-when-running-a-simulation-with-MultiZoneWithoutDistribution-and-fan branch January 8, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute approved these changes

@rraustad rraustad rraustad approved these changes

@tanaya-mankad tanaya-mankad tanaya-mankad approved these changes

Assignees

@kevin-moos kevin-moos

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when running a simulation with MultiZoneWithoutDistribution and a fan

6 participants

@kevin-moos @mitchute @rraustad @nrel-bot-2 @nrel-bot-2c @tanaya-mankad